Skip to content

Conversation

lixiliu
Copy link
Contributor

@lixiliu lixiliu commented Mar 6, 2025

Pull Request Description

  • Break out solar thermal from other fuel in Water Heater Fuel
  • Consolidate "Solar Hot Water" with "Water Heater Efficiency", which now defines the params for both solar thermal (type can be None) and a normal water heater. In OS-HPXML, all solar thermal must be connected to a secondary water heater.
  • Model a typical solar water heater with backup ER heating element in the tank as a solar collector (which has a tank of its own) + electric standard tank with EF 0.97 and R-6.2 jacket. The higher efficiency and insulation were used to minimize the standby loss (or UA) of the second tank, which other would consumes electricity even without backup use. A few notes to document from this experience:
    • "water_heater_standby_loss" in options_lookup is only used for combi boilers (also mentioned in OS-HPXML documentation). Changing that for tank WH does nothing.
    • "water_heater_recovery_efficiency" is 0.98 for electric tank by OS-HPXML default. Changing that value in options_lookup does not seem to override that. A test failed with an error of recovery efficiency not being higher than WH efficiency when the backup tank was assigned 0.98 for efficiency and 0.99 for recovery efficiency.
    • "water_heater_jacket_rvalue" can only go up to about R-6.2 before UA_adjusted becomes negative. And it varies by tank volume, and all sorts of variables. An 80 gal tank of EF 0.97 with a jacket r_val of 7 would already make ua_adj negative
    • Solar thermal loads can be negative or exorbitantly large. See issues Negative Solar Thermal Hot Water Load #1360 and Exorbitantly large solar thermal load #1365

This work is critical for HI integration where solar thermal is estimated to be a significant portion of Hawaii's total residential consumption and on par with rooftop solar according to our attempt to resolve the energy reporting from EIA 861/M and State Energy Data System:

Screenshot 2025-03-06 at 1 04 13 PM

More stats available in resstock-estimation companion PR

Related Pull Requests

resstock-estimation PR: https://github.com/NREL/resstock-estimation/pull/444

Related Issues

[What issue(s) is the PR addressing]

Checklist

Required:

Optional (not all items may apply):

@lixiliu lixiliu changed the title Updated tsvs Solar Hot Water Mar 6, 2025
@lixiliu lixiliu self-assigned this Mar 6, 2025
@afontani
Copy link
Contributor

@Sashadf1 : FYI. We are combining solar thermal water heating in with water heating and the options are changing here. I am not sure if you have done water heating.

@Sashadf1
Copy link
Collaborator

Sashadf1 commented Mar 26, 2025

@Sashadf1 : FYI. We are combining solar thermal water heating in with water heating and the options are changing here. I am not sure if you have done water heating.

@afontani Not yet, still working on HVAC (space conditioning) and probably appliances after that. I'll hold off on water heating until Lixi's PR gets merged.

@lixiliu lixiliu requested review from JLReyna and afontani April 2, 2025 20:52
@afontani afontani merged commit 3ce93a0 into develop Apr 10, 2025
7 checks passed
@afontani afontani deleted the ll/solar_hot_water branch April 10, 2025 14:30
@Sashadf1
Copy link
Collaborator

@Sashadf1 : FYI. We are combining solar thermal water heating in with water heating and the options are changing here. I am not sure if you have done water heating.

@afontani Not yet, still working on HVAC (space conditioning) and probably appliances after that. I'll hold off on water heating until Lixi's PR gets merged.

@afontani saw this just got merged, so I can tackle water heating w/ the new options.

@joseph-robertson joseph-robertson added this to the ResStock v2025_R1 milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants