Skip to content

Load flexibility yingli #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Mar 7, 2025
Merged

Load flexibility yingli #1331

merged 44 commits into from
Mar 7, 2025

Conversation

yingli-NREL
Copy link
Contributor

@yingli-NREL yingli-NREL commented Dec 13, 2024 •
edited
Loading

Pull Request Description

  1. Revise the peak time input json files and related code in the measure, which get rid of the variable "on_peak_duration"
  2. Add setpoint clip function to to prevent excessive heating or cooling
  3. Revise the default value of the load flexibility scenario design
  4. Did a local test run, the run is successful
  5. Add the test to test the run of the whole measure and setpoints are modified as designed

@yingli-NREL yingli-NREL requested a review from rajeee December 13, 2024 22:45
rajeee
rajeee reviewed Dec 16, 2024
View reviewed changes
resources/options_lookup.tsv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changes are you making on this file? Is it required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the loadflex_peak_duration_hours argument in the LoadFlexibility

yingli-NREL
yingli-NREL commented Dec 24, 2024
View reviewed changes
Copy link
Contributor Author

@yingli-NREL yingli-NREL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed all comments

resources/options_lookup.tsv
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the loadflex_peak_duration_hours argument in the LoadFlexibility

@yingli-NREL yingli-NREL self-assigned this Dec 24, 2024
@willf willf mentioned this pull request Feb 12, 2025
Open
@rajeee rajeee merged commit 482ecdf into load_flexibility Mar 7, 2025
1 of 2 checks passed
@rajeee rajeee deleted the load_flexibility_yingli branch March 27, 2025 15:35
@joseph-robertson joseph-robertson added this to the ResStock v2025_R1 milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajeee rajeee rajeee left review comments

Assignees

@yingli-NREL yingli-NREL

Labels

None yet

Projects

None yet

Milestone

ResStock v2025_R1

Development

Successfully merging this pull request may close these issues.

3 participants

@yingli-NREL @rajeee @joseph-robertson