Skip to content

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Aug 19, 2022

Pull Request Description

Companion PR to this: https://github.com/NREL/resstock-estimation/pull/245

Some TSVs have "Option=Void" as one of the available options. The idea behind Void is that certain dependency conditions are structurally impossible. For example, for "HVAC Heating Type and Fuel.tsv", it's impossible that "Heating Fuel" = Electricity and "HVAC Heating Efficiency" = "Fuel Boiler". So, this particular dependency condition get's Void option.

For other TSVs that have "HVAC Heating Type and Fuel.tsv" as a dependency, we don't need rows where "HVAC Heating Type and Fuel"="Void" since "HVAC Heating Type and Fuel" will never take up that value (if it does; it's an integrity error). There are tests in restock estimation that flags this integrity error.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@rajeee rajeee merged commit 3c64ceb into develop Aug 22, 2022
@rajeee rajeee deleted the low_samples branch August 22, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants