TSV changes from improved low samples handling #981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Companion PR to this: https://github.com/NREL/resstock-estimation/pull/245
Some TSVs have "Option=Void" as one of the available options. The idea behind Void is that certain dependency conditions are structurally impossible. For example, for "HVAC Heating Type and Fuel.tsv", it's impossible that "Heating Fuel" = Electricity and "HVAC Heating Efficiency" = "Fuel Boiler". So, this particular dependency condition get's Void option.
For other TSVs that have "HVAC Heating Type and Fuel.tsv" as a dependency, we don't need rows where "HVAC Heating Type and Fuel"="Void" since "HVAC Heating Type and Fuel" will never take up that value (if it does; it's an integrity error). There are tests in restock estimation that flags this integrity error.
Checklist
Not all may apply:
openstudio tasks.rb update_measures
has been run