Skip to content

Add Windows-specific directory creation for gs_platform_dir_exists_default_impl #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
reshen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Windows-specific directory creation for gs_platform_dir_exists_default_impl #107

reshen wants to merge 1 commit into from

Conversation

@reshen
Copy link

@reshen reshen commented Dec 4, 2025

In msvc, turns out mkdir only takes a single argument so this code needs a minor tweak to handle that case. While I was looking at the official docs, also noticed that mkdir is deprecated in favor of _mkdir, so made that change as well.

Without this patch:

**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.14.18
** Copyright (c) 2025 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x86'

...

gs_project_template> proc\win\cl.bat
The system cannot find the file specified.
Microsoft (R) C/C++ Optimizing Compiler Version 19.44.35219 for x86
Copyright (C) Microsoft Corporation.  All rights reserved.

main.c
C:\Users\reshen\gamedev\learn-c\gs_project_template\third_party\include\gs\impl/gs_platform_impl.h(722): error C2197: 'int mkdir(const char *)': too many arguments for call

With this patch:

gs_project_template> proc\win\cl.bat
Microsoft (R) C/C++ Optimizing Compiler Version 19.44.35219 for x86
Copyright (C) Microsoft Corporation.  All rights reserved.

main.c
Microsoft (R) Incremental Linker Version 14.44.35219.0
Copyright (C) Microsoft Corporation.  All rights reserved.

/debug
/out:App.exe
/SUBSYSTEM:CONSOLE
/NODEFAULTLIB:msvcrt.lib
/NODEFAULTLIB:LIBCMT
opengl32.lib
kernel32.lib
user32.lib
shell32.lib
vcruntime.lib
msvcrt.lib
gdi32.lib
Winmm.lib
Advapi32.lib
main.obj

gs_project_template> ls bin
App.exe  App.ilk  App.pdb  main.obj  vc140.pdb

p.s. Gunslinger is super cool, and your YT videos are fantastic. Appreciate you sharing your knowledge.

@reshen
Add Windows-specific directory creation for gs_platform_mkdir_default…
a06a9ad 
…_impl

In msvc, turns out `mkdir` only takes a single argument so this code needs a minor tweak to handle that case. While I was looking at [the official docs](https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/mkdir?view=msvc-170), also noticed that `mkdir` is deprecated in favor of `_mkdir`, so made that change as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@reshen