Skip to content

Conversation

@Salam-Dalloul
Copy link
Contributor

@Salam-Dalloul Salam-Dalloul commented Apr 5, 2025

@Salam-Dalloul Salam-Dalloul requested a review from ddelpiano April 7, 2025 12:11
@Salam-Dalloul Salam-Dalloul marked this pull request as ready for review April 7, 2025 12:11
@ddelpiano ddelpiano requested a review from afonsobspinto April 8, 2025 09:55
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running into an infinite loop when trying to recreate the statement where the original problem was reported:
https://composer.sckan.dev.metacell.us/statement/528

2025-04-08.12-18-49.mp4

@afonsobspinto afonsobspinto self-requested a review April 8, 2025 13:21
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to consistently replicate the infinite loop issue; changes wise I don't see what could be causing it so I'm cautiously approving this PR (since it solves the original problem) but we should keep an eye (maybe create a card @ddelpiano) on the infinite loop problem

@ddelpiano ddelpiano merged commit d243d46 into develop Apr 11, 2025
1 check passed
@ddelpiano ddelpiano deleted the bug/SCKAN-416 branch July 22, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants