Fix #8162: Fixed Visibility of Transit & On Order Stock in Repair Bay #8172
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8172 +/- ##
=========================================
Coverage 11.74% 11.75%
+ Complexity 7526 7525 -1
=========================================
Files 1267 1267
Lines 162223 162212 -11
Branches 24446 24444 -2
=========================================
+ Hits 19061 19062 +1
+ Misses 141155 141142 -13
- Partials 2007 2008 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #8162 where transit and on-order stock information was incorrectly hidden in the Repair Bay when armor parts were being salvaged from units. The changes also include code cleanup through the introduction of static imports for ReportingUtilities methods.
Key changes:
- Fixed the visibility of transit and on-order stock for armor during salvage operations
- Refactored code to use static imports for
ReportingUtilitieshelper methods, improving readability - Standardized the string building pattern for formatted messages across multiple files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Armor.java | Restructured conditional logic to display stock and transit/order information for both repair and salvage operations; added static imports and removed direct MekHQ reference |
| AmmoBin.java | Refactored to use static imports for ReportingUtilities methods, replacing verbose MekHQ.getMHQOptions() calls with cleaner helper method calls |
| MissingPart.java | Applied consistent static imports and improved string building pattern for transit/order details display, replacing string concatenation with builder pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix #8162
We were unintentionally excluding transit & on order stock for armor when the unit was set to salvage. I also cleaned up the methods a little.