Skip to content

Conversation

@arusahni
Copy link
Contributor

Motivation

  • This PR adds a feature that has not yet been specified.
    Hugo uses Chroma for syntax highlighting. We upstreamed a Materialize-specific syntax to ensure our dialect's keywords are recognized as such. Now that the end-to-end change is in prod, let's automate the process of generating updates for the dialect lexer.

I have a PR filed against the Chroma repo that uses a version of the lexer generated by this script.

Tips for reviewer

Checklist

no user facing behavior changes

Hugo uses Chroma for syntax highlighting. We upstreamed a
Materialize-specific syntax to ensure our dialect's keywords are
recognized as such. Now that the end-to-end change is in prod, let's
automate the process of generating updates for the dialect lexer.
Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making this usable by other folks on the team.

@arusahni arusahni merged commit 77ee7e7 into MaterializeInc:main Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants