This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Adding pulseaudio dependencies #2388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you. Works very well, merging! |
Contributor
|
But distros might intentionally not ship with PulseAudio since they use plain ALSA instead, or admins might have intentionally chosen to do so. Installing PA forcefully might interfere and break their usual audio setup. Mycroft can be configured to use ALSA commands instead of PA commands, so PA is not strictly required to make it run. IMO it makes sense to keep the audio backend choice, at least an option to make the automated PA install optional. I'll open a PR for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
pulseaudiodependencies. Some Debian based distributions (Raspbian, for example) do not have pre-installedpulseaudio-utilsthat is required to run some commands likepaplay.How to test
Run the
./dev_setup.shand make sure that thepaplay some_file.wavis working.