This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Speech client error handling #2372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a STT backend fails to load log the exception and fallback to the MycroftSTT.
Account ID will now be refetched if invalid the first time. This also adds some general exception handling to avoid client crashing due to the servers invalid 204 response.
davidwagnerkc
approved these changes
Oct 29, 2019
chrisveilleux
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add extra error handling to speech client
How to test
Make sure the speech client is still usable. Inject an exception in a STT backend interface's
__init__()and make sure it falls back to MycroftSTTContributor license agreement signed?
CLA [ Yes ]