Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

frames to read must be greater than 0 #2377

Merged
merged 1 commit into from
Nov 1, 2019
Merged

frames to read must be greater than 0 #2377

merged 1 commit into from
Nov 1, 2019

Conversation

@krisgesling
Copy link
Contributor

@krisgesling krisgesling commented Nov 1, 2019

Description

Received the following error on a Mark 1:

2019-10-22 00:31:53.324 | INFO     |   826 | mycroft.messagebus.client.client:on_open:67 | Connected
ALSA lib pcm.c:7843:(snd_pcm_recover) overrun occurred
ALSA lib pcm.c:7846:(snd_pcm_recover) cannot recovery from overrun, prepare failed: Input/output error
Expression 'alsa_snd_pcm_prepare( stream->capture.pcm )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 2932
Expression 'AlsaStart( stream, 0 )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 3246
Expression 'AlsaRestart( self )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 3313
Expression 'PaAlsaStream_HandleXrun( stream )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 4503
2019-10-30 04:41:05.137 | ERROR    |   826 | mycroft.client.speech.listener:run:108 | Exception in AudioProducer
Traceback (most recent call last):
  File "/opt/venvs/mycroft-core/lib/python3.4/site-packages/mycroft/client/speech/listener.py", line 84, in run
    self.stream_handler)
  File "/opt/venvs/mycroft-core/lib/python3.4/site-packages/mycroft/client/speech/mic.py", line 594, in listen
    ww_frames = self._wait_until_wake_word(source, sec_per_buffer)
  File "/opt/venvs/mycroft-core/lib/python3.4/site-packages/mycroft/client/speech/mic.py", line 478, in _wait_until_wake_word
    chunk = self.record_sound_chunk(source)
  File "/opt/venvs/mycroft-core/lib/python3.4/site-packages/mycroft/client/speech/mic.py", line 253, in record_sound_chunk
    return source.stream.read(source.CHUNK, self.overflow_exc)
  File "/opt/venvs/mycroft-core/lib/python3.4/site-packages/mycroft/client/speech/mic.py", line 99, in read
    exception_on_overflow=of_exc)
  File "/opt/venvs/mycroft-core/lib/python3.4/site-packages/pyaudio.py", line 608, in read
    return pa.read_stream(self._stream, num_frames, exception_on_overflow)
ValueError: Invalid number of frames

Currently unable to replicate the error consistently, however digging into the pyaudio code the exception is raised if num_frames being passed to pa.read_stream() is less than 0.

In MutableStream.read() it seems plausible that
to_read = min(self.wrapped_stream.get_read_available(), remaining)
could assign a negative number.

Hence this change to not only prevent passing a 0 value, but also that the number is not negative.

How to test

  • Unable to consistently replicate issue.
  • Mycroft-core unit tests continue to pass.
  • Ensure that mic stream is still read correctly

Contributor license agreement signed?

  • CLA

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Nov 1, 2019
@krisgesling
Copy link
Contributor Author

krisgesling commented Nov 1, 2019

run test

@forslund forslund force-pushed the fix/frame-value-error branch from bf71cf1 to 0197a7e Compare November 1, 2019 07:16
@forslund forslund merged commit 81d4366 into MycroftAI:dev Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krisgesling @forslund @devs-mycroft