Remove ntp sync reboot #2326
Remove ntp sync reboot #2326
Conversation
|
I understand why you'd want to get rid of this, but keep an eye on it. I don't recall the exact symptoms, but it involved an image which was months old being booted for the first time. In the startup sequence, the sudden passage of those "months" in one clock tick had some squirrelly effects on the system. This was a little ham-handed, but it was the most reliable solution at the time and seemed reasonable during that case. Perhaps the one-hour threshold was too aggressive -- I was trying to make it deal reasonably with the unplug, move and replug scenario. Not saying you should avoid doing this, but be sure to test the impact of a really long restart. On the Raspberry Pi they use a thing called fake-hwclock to save the current time in a file at shutdown, then reset the clock on boot. You can potentially edit that file to simulate a long dormancy -- look for /etc/fake-hwclock.data. |
|
Thanks I was just testing with setting the date manually back a day. I can
try months and try it with that file rather than the date command as well.
…On Wed, Sep 25, 2019 at 12:33 PM Steve Penrod ***@***.***> wrote:
I understand why you'd want to get rid of this, but keep an eye on it. I
don't recall the exact symptoms, but it involved an image which was months
old being booted for the first time. In the startup sequence, the sudden
passage of those "months" in one clock tick had some squirrelly effects on
the system. This was a little ham-handed, but it was the most reliable
solution at the time and seemed reasonable during that case. Perhaps the
one-hour threshold was too aggressive -- I was trying to make it deal
reasonably with the unplug, move and replug scenario.
Not saying you should avoid doing this, but be sure to test the impact of
a really long restart. On the Raspberry Pi they use a thing called
fake-hwclock
<https://manpages.debian.org/jessie/fake-hwclock/fake-hwclock.8.en.html>
to save the current time in a file at shutdown, then reset the clock on
boot. You can potentially edit that file to simulate a long dormancy --
look for /etc/fake-hwclock.data.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2326?email_source=notifications&email_token=AE4RVZ2USVMPSGHFLVIYYFDQLOOFDA5CNFSM4I2L2UKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7SWY7I#issuecomment-535129213>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE4RVZ7CQ3GOCHTNWEW6LZLQLOOFDANCNFSM4I2L2UKA>
.
|
|
Did more tests with changing clock back a year and also tested with fresh Mark 1 image that was from June, removing ntp reboot and adding in monotonic time for pairing code expiration (MycroftAI/skill-pairing@2e42197). All test continue to look good. Merging. |
Description
Reboot after NTP sync is no longer necessary with the changes to the skills process startup.
How to test
Boot up device with no network connection or identity file. Set date back:
sudo date -s "Sep 23 20:40:13 UTC 2019"and continue to setup wifi, pair device and confirm it works as expected.Contributor license agreement signed?
CLA [Yes ] (Whether you have signed a CLA - Contributor Licensing Agreement