This repository was archived by the owner on Sep 8, 2024. It is now read-only.
bugfix/adapt munging #2303
Merged
bugfix/adapt munging #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Works great, merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if a keyword contains the skill id there is a mismatch between registered keyword and keyword required by intents
depending on the name of the skill adapt keywords can get incorrectly munged when registering intent, this causes intents to be registered to a keyword without the skill id, while the keyword itself was correctly munged and contains the skill id
took me a while to understand why some intents magically would not trigger, until i renamed the skill and everything started working
How to test
register a keyword containing the skill_id
Contributor license agreement signed?
CLA [yes ] (Whether you have signed a CLA - Contributor Licensing Agreement