Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 30, 2019

Description

(Description of what the PR does, such as fixes # {issue number})

$ python

>>> 1 == 1.0
True
>>> 1 is 1.0
False

How to test

(Description of how to validate or test this PR)

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

Identity is not the same thing as equality in Python

$ python
```
>>> 1 == 1.0
True
>>> 1 is 1.0
False
```
@devs-mycroft
Copy link
Collaborator

Hello, @cclauss, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@devs-mycroft devs-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Jul 30, 2019
@krisgesling
Copy link
Contributor

Thanks Christian,

Based off your commit messages I'm guessing you have already completed the CLA form. This is a slightly manual process on our end to avoid abuse, but let me know if an email doesn't arrive and I'll give them a nudge.

Once we have confirmation that it's signed we can merge this in, and the best part is you only have to deal with the CLA once :)

@krisgesling
Copy link
Contributor

This was actually one of my commits and good to have it flagged. I'm relatively new to Python and was thinking of is and == as synonymous, I even tried to use is more to force myself to be more 'Pythonic'. However I can see now that is compares identities not values which makes a whole lot of sense.

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Aug 7, 2019
@krisgesling krisgesling merged commit 754da78 into MycroftAI:dev Aug 7, 2019
@cclauss cclauss deleted the patch-2 branch August 8, 2019 04:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants