This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Skills process startup speedup #2197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade msm to 0.7.8 Using the new max_threads parameters to MycroftSkillsManager.apply() the skill loading is reduced to 2 threads if it's during runtime while a fast update (20 threads) are used if not all default skills are installed to speed up getting core into a 100% operational state.
Checks if the skills haven't been updated for more than 2 weeks or if the last_download is undefined. last_download may be undefined if the .msm file is missing or if the list of installed requirements is missing so skill requirements may be missing. This also makes sure the skills are normally loaded before the an update attemt is tried.
Skill manifest is now sent on each startup if paired otherwise after successful pairing.
3ad30cf to
94ab53f
Compare
Collaborator
Author
|
Msm has been released with the max_thread support so this can now be tested. Suggestions for other improvements are welcome. |
davidwagnerkc
approved these changes
Jul 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try to speed up the skills process startup.
This depends on a pending change in msm to allow reducing the number of threads used by the msm.apply() method.
I'm also testing how it behaves when loading skills in parallel using a thread pool.
How to test
Assert the skills are loaded and updated as normal, with any luck some of the blocking calls have been removed from the critical path and a speedup can be seen.
Contributor license agreement signed?
CLA [ Yes ]