Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Conversation

@forslund
Copy link
Collaborator

Rebase of @JarbasAI's PR #858

  • updated skill id method
  • added pairing to default priority list
  • changed waiting for all skills to wait for priority skills before starting the network detector to increase startup time when pairing is needed.

@forslund forslund requested a review from penrods September 15, 2017 06:13
Copy link
Contributor

@penrods penrods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forslund
Copy link
Collaborator Author

travis got interrupted at some point it seems

@forslund forslund added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Sep 15, 2017
@JarbasAI
Copy link
Contributor

much cleaner than my approach :)

JarbasAl and others added 3 commits September 15, 2017 13:31
====  Tech Notes ====
- Set pairing as a priority skill by default
- Move priority loading to separate function
====  Tech Notes ====
The network check is now only delayed until priority skills have been
loaded (this includes the relevant pairing skill)
@forslund forslund force-pushed the feature/jarbas-priority-skills branch from 61ca294 to a068d53 Compare September 15, 2017 11:32
@penrods penrods merged commit f756673 into MycroftAI:dev Sep 15, 2017
@forslund forslund deleted the feature/jarbas-priority-skills branch September 22, 2017 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants