This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Add messages for skill handler's starting/stopping #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
==== Tech Notes ==== Add message bus messages when a skill handler is starting to execute and a separate message for when skill handler completes. Usable if grouping speech in certain clients for example. Can also be of use for audio ducking and similar processes. ==== Protocol Notes ==== Adds the following messages: mycroft.skill.handler.start mycroft.skill.handler.complete
Contributor
|
damn, you beat me to it xD i had this one ready to PR the one thing i did differently was that i also added a .fail message mycroft.skill.handler.failure with the error in data |
Collaborator
Author
|
Great minds think alike :) I'll add something along those lines. |
==== Tech Notes ==== The handler name (including class if available) is sent along in the data field. If an exception is raised an exception field in the data is added with minor information of the problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==== Tech Notes ====
Add message bus messages when a skill handler is starting to execute and
a separate message for when skill handler completes. Usable if grouping
speech in certain clients for example. Can also be of use for audio
ducking and similar processes.
==== Protocol Notes ====
Adds the following messages:
mycroft.skill.handler.start
mycroft.skill.handler.complete