This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Mimic cpu calc rebase by el-tocino #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@forslund the code looks good but there is a conflict on dev_setup can you rebase it? thank you |
640a1e5 to
72d4207
Compare
Contributor
|
@aatchison You good with this being merged? If so, please do! |
aatchison
approved these changes
Aug 17, 2017
Contributor
aatchison
left a comment
There was a problem hiding this comment.
Looking good, I saw this earlier and I like it. My only crit would be to use lower case letters for variable names, if they are not system environment variables (to avoid potential conflict.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==== Fixed Issues ====
Partially resolves #982
==== Tech Notes ====
Handles an error which may occur when checking for mimic
Automatically determines how many cores can be use to compile mimic depending on system memory. The system approximates that the maximum memory required will be ~500MB