Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Fixing wakeword save #971

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Fixing wakeword save #971

merged 1 commit into from
Aug 9, 2017

Conversation

@reginaneon
Copy link
Contributor

@reginaneon reginaneon commented Aug 8, 2017 •
edited by augustnmonteiro
Loading

==== Tech Notes ====
Fixing method name to create audio data

@reginaneon
Bug Fix
c96d0a3 
Bug fix proposed for success wake-word recording. 
Opt: Suggestion to change the save location of recording files as well. 
Otherwise, the user could potentially get the permission denial. 
-NeonGecko.com Inc
@coveralls
Copy link

coveralls commented Aug 8, 2017

Coverage Status

Coverage remained the same at 40.675% when pulling c96d0a3 on reginaneon:patch-1 into ab22106 on MycroftAI:dev.

@augustnmonteiro augustnmonteiro self-requested a review August 9, 2017 17:43
augustnmonteiro
augustnmonteiro approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@augustnmonteiro augustnmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @reginaneon, LGTM 👍

@augustnmonteiro augustnmonteiro changed the title Bug Fix Fixing wakeword save Aug 9, 2017
@augustnmonteiro augustnmonteiro merged commit f2e9d6b into MycroftAI:dev Aug 9, 2017
@penrods
Copy link
Contributor

penrods commented Aug 18, 2017

Hey @reginaneon, the PR slipped in just as I was implementing the new CLA (Contributor Licensing Agreement) system for Mycroft contributors. The CLA makes it crystal clear that you are giving the project and users of the project license to use your code, but that you still own your contributed code.

Can you please out the CLA at https://mycroft.ai/cla? Let me know if you have any questions about it.
Thank you!

@penrods penrods added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Aug 18, 2017
@reginaneon
Copy link
Contributor Author

reginaneon commented May 4, 2018

@augustnmonteiro @penrods CLA received and signed.

@reginaneon reginaneon deleted the patch-1 branch May 4, 2018 22:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@augustnmonteiro augustnmonteiro augustnmonteiro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA: Needed Need signed CLA from https://mycroft.ai/cla

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reginaneon @coveralls @penrods @augustnmonteiro