This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Altered prepare-msm.sh to #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a function to change ownership Added an ownership check that is always run in the case of a botched run the first time
MatthewScholefield
approved these changes
Aug 2, 2017
Contributor
MatthewScholefield
left a comment
There was a problem hiding this comment.
Looks good! Only thing to note is that if /opt/mycroft is user:user but /opt/mycroft/skills is root:root, it won't change ownership, but I don't think this is something we have to worry about.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change permissions to the correct user in /opt/mycroft
Added a function to change ownership
Added an ownership check that is always run in the case of a botched run the first time