This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Check queue empty with self.queue.empty() instead of len() #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recognizer_loop:audio_output_start message will only be sent if the queue has been empty since last loop.
MatthewScholefield
approved these changes
Jul 7, 2017
Contributor
MatthewScholefield
left a comment
There was a problem hiding this comment.
Lgtm! Didn't even realize len wasn't implemented for Queue xD.
Contributor
|
Tested and it now works properly. |
Harika-kothuru
pushed a commit
that referenced
this pull request
Jul 18, 2017
* Check queue empty with self.queue.empty() instead of len() * Add error logging of exceptions in tts thread. * Limit the number of audio_output_start messages. recognizer_loop:audio_output_start message will only be sent if the queue has been empty since last loop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #893.