This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Closes #801 - Refactor setup_base to use CORE_VERSION_STR #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Okie, I'm on it |
Contributor
|
@aatchison This good? If so let's merge |
Contributor
|
Oops, I do believe this works but I had better check again because I don't remember. |
aatchison
approved these changes
Jul 5, 2017
Contributor
Author
|
The travis build on this is failing, do we have issues with travis normally in our tests right now or do I need to rebase? |
dc5af31 to
88d388f
Compare
Contributor
Author
|
Tests are passing, this is good to go! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the get_version method to get the version from CORE_VERSION_STR instead of the deprecated version. This also doesn't have the issue of the previous PR, where it would check for a file that doesn't exist during the build process, and so break packaging. @aatchison, it would be good if you could double check that this works for the current packaging process.