This repository was archived by the owner on Sep 8, 2024. It is now read-only.
TTS playback thread #804
Merged
TTS playback thread #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
321614c to
876f730
Compare
penrods
reviewed
Jul 6, 2017
Contributor
penrods
left a comment
There was a problem hiding this comment.
I like it. Let's get this merged. I also need to test this on a Mark 1 to see if it resolves the bad behavior of the button for Stop, but regardless this is a cleaner approach to build upon.
penrods
approved these changes
Jul 6, 2017
Contributor
penrods
left a comment
There was a problem hiding this comment.
Can you resolve the conflicts and go ahead a merge.
When - Updating tts config - KeyboardInterrupt
876f730 to
3be91fb
Compare
Collaborator
Author
|
Conflicts resolved, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a thread to play audio allows TTS to generate new speech in the background. This should give muliti-sentence speech a more natural speed for slower devices.
There is also quite a bit of refactoring allowing the other TTS backends to use the caching mechanism and possibly Visimes in the future.