This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Allow test to finsh immediately #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cleanup procedure to skills: MycroftSkill cleanup does nothing, ScheduledSkill will cancel running timers to make sure it's not blocking termination. Tests updated to use this allowing unit test to exit after completion.
aa42e41 to
6eb89a7
Compare
Collaborator
Author
|
Not sure where the conflict came from, but it's rebased and clean now. |
aatchison
approved these changes
Jan 20, 2017
forslund
added a commit
to forslund/mycroft-core
that referenced
this pull request
Feb 9, 2017
Add cleanup procedure to skills: MycroftSkill cleanup does nothing, ScheduledSkill will cancel running timers to make sure it's not blocking termination. Tests updated to use this allowing unit test to exit after completion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a way to fix #447
What it does
The PR adds a cleanup method to skills and allows this to be run when calling
unload_skills(). For scheduled skills this cancels running timers that would be blocking termination. (as timers reference a class method the class won't be garbage collected)The
unload_skills()method is now called when the skill intent test is teared down allowing the unittest to finish directly.