Skip to content

Conversation

@peterpru
Copy link
Contributor

@peterpru peterpru commented Oct 25, 2024

  • This comment contains a description of changes (with reason)

This is a PR for a new module, haplocheck, specifically for its contamination output.

  • There is example tool output for tools in the https://github.com/MultiQC/test-data repository or attached to this PR
  • Code is tested and works locally (including with --strict flag)
  • Everything that can be represented with a plot instead of a table is a plot
  • Report sections have a description and help text (with self.add_section)
  • There aren't any huge tables with > 6 columns (explain reasoning if so)
  • Each table column has a different colour scale to its neighbour, which relates to the data (e.g. if high numbers are bad, they're red)
  • Module does not do any significant computational work

@peterpru
Copy link
Contributor Author

peterpru commented Nov 4, 2024

PR for test data: MultiQC/test-data#339

@peterpru
Copy link
Contributor Author

peterpru commented Nov 4, 2024

Runs on local:
image

image

@peterpru peterpru marked this pull request as ready for review November 4, 2024 13:30
@vladsavelyev vladsavelyev added waiting: changes Issue / PR is on hold, waiting for requested changes module: new labels Nov 13, 2024
@vladsavelyev vladsavelyev added waiting: changes Issue / PR is on hold, waiting for requested changes and removed waiting: changes Issue / PR is on hold, waiting for requested changes labels Nov 18, 2024
@vladsavelyev vladsavelyev merged commit b1fa683 into MultiQC:main Nov 18, 2024
10 checks passed
@vladsavelyev
Copy link
Member

Thank you Peter for the contribution!

@vladsavelyev vladsavelyev modified the milestones: v1.25.2, v1.26 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: new waiting: changes Issue / PR is on hold, waiting for requested changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants