Skip to content

fix: don't skip export generation for default reexport #19463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexander-akait merged 1 commit into from
Apr 24, 2025
Merged

fix: don't skip export generation for default reexport #19463

alexander-akait merged 1 commit into from
Apr 24, 2025

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Apr 24, 2025

What kind of change does this PR introduce?

fixes #19451

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025

Benchmarks:

  • "devtool-source-map": HEAD (a7b16f1) 672 ms ± 50 ms [660 ms; 684 ms] (49 runs)
  • "devtool-source-map": BASE (648e026) 650 ms ± 36 ms [641 ms; 658 ms] (50 runs)
  • "devtool-source-map" change: HEAD (672 ms ± 50 ms [660 ms; 684 ms]) is -3% slower than BASE (BASE) (650 ms ± 36 ms [641 ms; 658 ms])
  • "many-chunks": HEAD (a7b16f1) 1102 ms ± 39 ms [1091 ms; 1114 ms] (32 runs)
  • "many-chunks": BASE (648e026) 1091 ms ± 43 ms [1078 ms; 1104 ms] (32 runs)
  • "many-chunks" change: HEAD (1102 ms ± 39 ms [1091 ms; 1114 ms]) is -1% the same as BASE (BASE) (1091 ms ± 43 ms [1078 ms; 1104 ms])
  • "many-modules": HEAD (a7b16f1) 597 ms ± 26 ms [591 ms; 603 ms] (54 runs)
  • "many-modules": BASE (648e026) 613 ms ± 32 ms [606 ms; 620 ms] (53 runs)
  • "many-modules" change: HEAD (597 ms ± 26 ms [591 ms; 603 ms]) is 3% faster than BASE (BASE) (613 ms ± 32 ms [606 ms; 620 ms])
  • "popular-libraries": HEAD (a7b16f1) 1526 ms ± 39 ms [1512 ms; 1540 ms] (24 runs)
  • "popular-libraries": BASE (648e026) 1544 ms ± 52 ms [1526 ms; 1562 ms] (24 runs)
  • "popular-libraries" change: HEAD (1526 ms ± 39 ms [1512 ms; 1540 ms]) is 1% the same as BASE (BASE) (1544 ms ± 52 ms [1526 ms; 1562 ms])

@alexander-akait alexander-akait merged commit dc33a1e into main Apr 24, 2025
58 checks passed
@alexander-akait alexander-akait deleted the issue-19451 branch April 24, 2025 17:28
3ru pushed a commit to 3ru/webpack that referenced this pull request Jul 1, 2025
@alexander-akait @3ru
fix: don't skip export generation for default reexport (webpack#19463)
2bce4f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

regression: missing named exports for asset/inline with output.module in Webpack 5.99.0+

1 participant

@alexander-akait