fix(browser): fix import.meta.env define
#9205
Merged
+21
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9191
Problems
state.metaEnv = import.meta.envin browsertester.tsis transformed to{ "MODE": "production", ...}due tovite buildduring@vitest/browserpackaging. Later we mutate and overridemetaEnvwithconfig.env, but this logic doesn't accommodateimport.meta.envdefine and doesn't match with Vite dev behavior on browser mode. (On SSR, bothimport.meta.envdefine get merged toprocess.env, so defines works on runtime).Solutions
I'm not sure this is the only way, but I replaced with a marker
__vitest_browser_import_meta_env_init__to ensureimport.meta.envis processed by Vite (which happens during client import analysis).Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.