fix(happy-dom): support fetch globals #8791
Merged
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvHaus
reviewed
Oct 29, 2025
| 'Headers', | ||
| 'AbortController', | ||
| 'AbortSignal', | ||
| 'URL', |
Contributor
There was a problem hiding this comment.
@sheremet-va After upgrading to vitest 4.0.3 my happy-dom-based tests are now failing with:
ReferenceError: URL is not defined
❯ new Location ../../node_modules/.pnpm/[email protected]/node_modules/happy-dom/lib/location/Location.js:26:25
❯ new BrowserWindow ../../node_modules/.pnpm/[email protected]/node_modules/happy-dom/lib/window/BrowserWindow.js:708:41
❯ new Window ../../node_modules/.pnpm/[email protected]/node_modules/happy-dom/lib/window/Window.js:39:9
❯ new GlobalWindow ../../node_modules/.pnpm/[email protected]/node_modules/happy-dom/lib/window/GlobalWindow.js:10:16
❯ Object.setup ../../node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/vitest/dist/chunks/index.DON9WL-E.js:338:69
❯ processTicksAndRejections node:internal/process/task_queues:105:5
❯ withEnv ../../node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/vitest/dist/chunks/base.RFExFinv.js:55:14
❯ run ../../node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/vitest/dist/chunks/base.RFExFinv.js:72:144
❯ runBaseTests ../../node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/vitest/dist/chunks/base.RFExFinv.js:122:2
❯ executeTests ../../node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/vitest/dist/chunks/init-forks.WSf5dRNP.js:24:4
Could it be related to this change? Downgrading to vitest 4.0.2 makes the issue go away.
Member
Author
There was a problem hiding this comment.
Please, create an issue with a reproduction. A quick run of our happy-dom tests didn't show an error
6 tasks
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8777
Fixes #8788
We removed fetch related globals from the KEYS to support jsdom, but happy-dom does define them properly, so they need to stay in the happy-dom environment.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.