fix(browser): stop creating unnecessary directories when taking screenshots #8605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c55c3cd to
cde9b3a
Compare
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
macarie
commented
Sep 22, 2025
| // there seems to be a bug in webdriverio, `X:/` gets appended to cwd, so we convert to `X:\` | ||
| const buffer = await element.saveScreenshot( | ||
| savePathWithExtension, | ||
| platformNormalize(savePathWithExtension), |
Member
Author
There was a problem hiding this comment.
As said in the comment above, we need to change X:/ to X:\ when using Windows, so the simplest thing we can do is to use normalize from node:path and normalize only this path.
cde9b3a to
4aea1aa
Compare
3 tasks
sheremet-va
approved these changes
Sep 24, 2025
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8604
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.