Skip to content

perf: use experimental meta.resolve flag instead of a custom loader #8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheremet-va merged 7 commits into from
Sep 16, 2025
Merged

perf: use experimental meta.resolve flag instead of a custom loader #8567

sheremet-va merged 7 commits into from
Sep 16, 2025

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Sep 12, 2025

Description

Calling module.register can take up to ~15ms. Let's instead just use built-in mechanism.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Sep 12, 2025 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 67bf9a6
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68c82d1293da20000870ff4e
😎 Deploy Preview https://deploy-preview-8567--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa
hi-ogawa reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove these ignore comments?

vitest/packages/vitest/src/runtime/moduleRunner/moduleRunner.ts

Lines 13 to 18 in 934e0d0

// eslint-disable-next-line ts/ban-ts-comment
// @ts-ignore available since Vite 7.1 https://github.com/vitejs/vite/pull/20260
export type CreateImportMeta = NonNullable<viteModuleRunner.ModuleRunnerOptions['createImportMeta']>
// eslint-disable-next-line ts/ban-ts-comment
// @ts-ignore
export const createNodeImportMeta: CreateImportMeta = (modulePath: string) => {

@sheremet-va sheremet-va merged commit 2e0630b into vitest-dev:main Sep 16, 2025
13 of 14 checks passed
This was referenced Nov 3, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hi-ogawa hi-ogawa hi-ogawa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sheremet-va @hi-ogawa