fix: distribute test files to shards more evenly #8288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #8244
In current implementation, test files are distributed with
Math.ceil(files.length / count)in{index}/{count}shard setting.This causes #8244 because this ceil based distribution logic can consume all test files by shards without the ending shard.
In addition to this, I believe this logic causes a bit lower performance in an edge-case like:
--shard index/3In the above case, test files will be distributed as
[3, 3, 3, 1]but I think it is more ideal to be distributed as[3, 3, 2, 2]in the point of parallelism.This PR fixes this issue by introducing distribution logic based on
Math.floor(files.length / count)instead ofMath.ceilPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.