fix(runner): fix and simplify `Task.suite` initialization #7414

hi-ogawa · 2025-02-04T05:14:36Z

Description

(Supersedes) closes fix(runner): correctly initialize suite in task #7374

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2025-02-04T05:17:08Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`c6e5322`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/67a1a240fbfd02000836b9a0
😎 Deploy Preview	https://deploy-preview-7414--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hi-ogawa · 2025-03-03T05:59:09Z

test/cli/fixtures/custom-runner/custom-runner.test.ts

+test("test-a", (ctx) => {
+	expect(ctx.__suiteNames).toEqual([]);
+})
+
+describe("suite-x", () => {
+	test("test-b", (ctx) => {
+		expect(ctx.__suiteNames).toEqual(
+			['suite-x']
+		)
+	})
+
+	describe("suite-y", () => {
+		test("test-c", (ctx) => {
+			expect(ctx.__suiteNames).toEqual(
+				['suite-y', 'suite-x']
+			)
+		})
+	})
+})


On #7374, some tests fail (and pass) in an odd way:

Details

DEV v3.0.7 /home/hiroshi/code/others/vitest/test/cli/fixtures/custom-runner ❯ custom-runner.test.ts (3 tests | 2 failed) 6ms × test-a 5ms → expected [ '' ] to deeply equal [] ✓ suite-x > test-b × suite-x > suite-y > test-c 1ms → expected [ 'suite-y' ] to deeply equal [ 'suite-y', 'suite-x' ] ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ FAIL custom-runner.test.ts > test-a AssertionError: expected [ '' ] to deeply equal [] - Expected + Received - [] + [ + "", + ] ❯ custom-runner.test.ts:6:27 4| 5| test("test-a", (ctx) => { 6| expect(ctx.__suiteNames).toEqual([]); | ^ 7| }) 8| ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯ FAIL custom-runner.test.ts > suite-x > suite-y > test-c AssertionError: expected [ 'suite-y' ] to deeply equal [ 'suite-y', 'suite-x' ] - Expected + Received [ "suite-y", - "suite-x", ] ❯ custom-runner.test.ts:18:29 16| describe("suite-y", () => { 17| test("test-c", (ctx) => { 18| expect(ctx.__suiteNames).toEqual( | ^ 19| ['suite-y', 'suite-x'] 20| ) ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/2]⎯ Test Files 1 failed (1) Tests 2 failed | 1 passed (3) Start at 14:56:29 Duration 147ms (transform 25ms, setup 0ms, collect 8ms, tests 6ms, environment 0ms, prepare 53ms)

pkg-pr-new · 2025-03-03T06:02:07Z

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7414

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7414

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7414

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7414

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7414

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7414

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7414

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7414

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7414

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7414

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7414

vite-node

npm i https://pkg.pr.new/vite-node@7414

vitest

npm i https://pkg.pr.new/vitest@7414

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7414

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7414

commit: 3461652

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/main/packages/coverage-v8#readme) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8)) | devDependencies | patch | [`3.0.7` -> `3.0.8`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-v8/3.0.7/3.0.8) | | [vitest](https://github.com/vitest-dev/vitest) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest)) | devDependencies | patch | [`3.0.7` -> `3.0.8`](https://renovatebot.com/diffs/npm/vitest/3.0.7/3.0.8) | --- ### Release Notes <details> <summary>vitest-dev/vitest (@vitest/coverage-v8)</summary> ### [`v3.0.8`](https://github.com/vitest-dev/vitest/releases/tag/v3.0.8) [Compare Source](vitest-dev/vitest@v3.0.7...v3.0.8) ##### 🐞 Bug Fixes - Fix fetch cache multiple writes - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7546 [<samp>(1a8b4)</samp>](vitest-dev/vitest@1a8b4337) - Use browser.isolate instead of config.isolate - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7560 [<samp>(4b5ed)</samp>](vitest-dev/vitest@4b5ed902) - Remove vestigial spy stub, import directly from `@vitest/spy` - by [@mrginglymus](https://github.com/mrginglymus) in vitest-dev/vitest#7575 [<samp>(7f7ff)</samp>](vitest-dev/vitest@7f7ff11c) - Correctly split the argv string - by [@btea](https://github.com/btea) in vitest-dev/vitest#7533 [<samp>(4325a)</samp>](vitest-dev/vitest@4325ac67) - **browser**: - Remove [@testing-library/dom](https://github.com/testing-library/dom) from dependencies - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7555 [<samp>(5387a)</samp>](vitest-dev/vitest@5387a5b3) - Improve source map handling for bundled files - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7534 [<samp>(e2c57)</samp>](vitest-dev/vitest@e2c570b6) - Print related test file and potential test in unhandled errors - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7564 [<samp>(fee90)</samp>](vitest-dev/vitest@fee90d85) - **runner**: - Fix `beforeEach/All` cleanup callback timeout - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7500 [<samp>(0c292)</samp>](vitest-dev/vitest@0c2924b7) - Fix and simplify `Task.suite` initialization - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7414 [<samp>(ca9ff)</samp>](vitest-dev/vitest@ca9ffac5) - **snapshot**: - Allow inline snapshot calls on same location with same snapshot - by [@jycouet](https://github.com/jycouet) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7464 [<samp>(d5cb8)</samp>](vitest-dev/vitest@d5cb8212) - **vite-node**: - Fix `buildStart` on Vite 6 - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7480 [<samp>(c0f47)</samp>](vitest-dev/vitest@c0f47e03) ##### [View changes on GitHub](vitest-dev/vitest@v3.0.7...v3.0.8) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.justinelmore.dev/jelmore1674/build-changelog/pulls/95 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

hi-ogawa added 3 commits February 3, 2025 18:21

wip

5230b92

fix: suite.suite too

22b8d13

refactor: minor

c6e5322

hi-ogawa mentioned this pull request Feb 4, 2025

fix(runner): correctly initialize suite in task #7374

Closed

6 tasks

hi-ogawa added 4 commits March 3, 2025 14:14

Merge branch 'main' into fix-early-task-suite

1ebd663

test: add tests

434b0db

chore: cleanup

3cc3d95

refactor: tweak createDefaultSuite

41906f0

hi-ogawa added the cr-tracked label Mar 3, 2025

hi-ogawa commented Mar 3, 2025

View reviewed changes

hi-ogawa marked this pull request as ready for review March 3, 2025 06:04

test: also confirm after

3461652

hi-ogawa requested a review from sheremet-va March 3, 2025 06:10

sheremet-va approved these changes Mar 3, 2025

View reviewed changes

sheremet-va merged commit ca9ffac into vitest-dev:main Mar 6, 2025
14 checks passed

hi-ogawa deleted the fix-early-task-suite branch March 6, 2025 23:10

maretol mentioned this pull request Mar 7, 2025

Bump the dependencies group across 3 directories with 5 updates maretol/maretol-base#349

Merged

renovate bot mentioned this pull request May 19, 2025

test(deps): update all test dependencies bucketeer-io/javascript-client-sdk#219

Merged

1 task

renovate bot mentioned this pull request Oct 3, 2025

chore(deps): update test pgalhardo/vue-remove-scroll-bar#13

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(runner): fix and simplify `Task.suite` initialization #7414

fix(runner): fix and simplify `Task.suite` initialization #7414

Uh oh!

hi-ogawa commented Feb 4, 2025 •

edited

Loading

Uh oh!

netlify bot commented Feb 4, 2025

Uh oh!

hi-ogawa Mar 3, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(runner): fix and simplify Task.suite initialization #7414

fix(runner): fix and simplify Task.suite initialization #7414

Uh oh!

Conversation

hi-ogawa commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

netlify bot commented Feb 4, 2025

✅ Deploy Preview for vitest-dev ready!

Uh oh!

hi-ogawa Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(runner): fix and simplify `Task.suite` initialization #7414

fix(runner): fix and simplify `Task.suite` initialization #7414

hi-ogawa commented Feb 4, 2025 •

edited

Loading

hi-ogawa Mar 3, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 3, 2025 •

edited

Loading