fix!: don't remove shiki styles from pre and remove unnecessary transformers
#4652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsformers BREAKING CHANGE: `vp-adaptive-theme` class is no longer added to code blocks when there is single theme. Theme authors supporting single code theme can use `.shiki:not(.shiki-themes)` as selector. Alternatively, it might be better to use the bg/fg variables set on the `.shiki` block to keep things generic. BREAKING CHANGE: `vp-code` class is no longer added to code blocks. Use `.shiki` or `pre.shiki` or `[class*='language-'] pre` instead. People not customizing their themes are not affected. But if you see weird stuff, you know what to change.
|
Are there some ways in |
|
I use const transformers = [
transformerNotationDiff(),
transformerNotationFocus({
classActiveLine: "has-focus",
classActivePre: "has-focused-lines"
}),
transformerNotationHighlight(),
transformerNotationErrorLevel(),
// {
// name: "vitepress:add-class",
// pre(node) {
// this.addClassToHast(node, "vp-code");
// }
// },
// {
// name: "vitepress:clean-up",
// pre(node) {
// delete node.properties.style;
// }
// }
]; |
|
You can use the nightly releases - |
|
Thanks! It looks better. Will the next alpha version include this PR? |
|
Yes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
vp-adaptive-themeclass is no longer added to code blocks when there is single theme. Theme authors supporting single code theme can use.shiki:not(.shiki-themes)as selector. Alternatively, it might be better to use the bg/fg variables set on the.shikiblock to keep things generic.BREAKING CHANGE:
vp-codeclass is no longer added to code blocks. Use.shikiorpre.shikior[class*='language-'] preinstead.People not customizing their themes are not affected. But if you see weird stuff, you know what to change.