feat: add option for reporting internal errors #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks a lot for the PR! I will have a look in more detail shortly, but looks good from a quick glance. |
tomarrell
reviewed
Mar 11, 2025
wrapcheck/wrapcheck.go
Outdated
| fnIdent, ok := call.Fun.(*ast.Ident) | ||
| if ok { | ||
| fnSig := pass.TypesInfo.ObjectOf(fnIdent).String() | ||
| pass.Reportf(tokenPos, "error should be unwrapped: sig: %s", fnSig) |
Owner
There was a problem hiding this comment.
I think the error message here should be more along the lines of error should be wrapped as the purpose of this is to identify incorrectly unwrapped errors.
Suggested change
| pass.Reportf(tokenPos, "error should be unwrapped: sig: %s", fnSig) | |
| pass.Reportf(tokenPos, "package-internal error should be wrapped: sig: %s", fnSig) |
Contributor
Author
There was a problem hiding this comment.
Thank you for your comment.
I have fixed the error messages.
tomarrell
reviewed
Mar 11, 2025
tomarrell
requested changes
Mar 11, 2025
Owner
tomarrell
left a comment
There was a problem hiding this comment.
Just a couple of questions, thanks a lot! 😃
067f50b to
e13f4da
Compare
tomarrell
approved these changes
Mar 11, 2025
Owner
tomarrell
left a comment
There was a problem hiding this comment.
Looks great, thanks a lot! Will soon cut a new release for these changes.
Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
ReportInternalErrorsoption to report internal errors.close #59