perf(minifier): use u8 for remaining_depth
#10833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
u8is enough for this field. Actually there are two more optimization we probably can do:unresolved_ctxtis rarely changed so we can avoid copying it when copyingExprCtx.u8But I don't want to do them, since they will make code messier and less extendable.
This pr makes
ExprCtxfrom 12 bytes to 8 bytes. 8 bits = 64 bits is good enough for now.