Skip to content

Conversation

@TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Mar 28, 2025

Adds generated code test for IObserable. I'm trying to add AOT support again 😞

Edit: the API approval test keeps failing is this normal?

@TimothyMakkison TimothyMakkison force-pushed the observable_generated branch 2 times, most recently from 676721e to 5244919 Compare March 28, 2025 17:15
@ChrisPulman
Copy link
Member

Hi @TimothyMakkison good to see you back, everything fell apart with some of the latest VS updates, I will take a look at the build to try and get things back on track.

@TimothyMakkison
Copy link
Contributor Author

Hi @TimothyMakkison good to see you back,

Thanks, can't guarantee that I'll ever add AOT, but I am making progress. I abandoned it after I realised I'd have to rewrite half of the tests 😅

everything fell apart with some of the latest VS updates, I will take a look at the build to try and get things back on track.

I'll change the PR to only include my changes

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (6ebeda5) to head (ce4345a).
Report is 174 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1960      +/-   ##
==========================================
- Coverage   87.73%   85.59%   -2.14%     
==========================================
  Files          33       36       +3     
  Lines        2348     2506     +158     
  Branches      294      365      +71     
==========================================
+ Hits         2060     2145      +85     
- Misses        208      283      +75     
+ Partials       80       78       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisPulman ChrisPulman merged commit 5331648 into reactiveui:main Mar 28, 2025
2 of 3 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants