Skip to content

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle commented Mar 6, 2025

Since Framework has so many files to update, I felt like this was a good breaking point for a first PR.

This PR implements the tfprotov{5/6}.ProviderServerWithResourceIdentity interface, for each RPC:

  • GetResourceIdentitySchemas: This PR contains about 95% of the implementation with the external packages/internal attribute updates and tests. The missing piece is validation on list attribute (see below).
  • UpgradeResourceIdentity: This RPC will be implemented in a separate PR
  • All of the RPCs that are just adding the identity data to the request/response will be implemented in a separate PR, but they are all additional data, so ignoring them is fine for existing providers.

Other related work for resource identity (coming soon)

  • Adding identity data to request/response of all existing RPCs
  • Validation logic for list attributes
  • Import Resource RPC updates
  • Upgrade Resource Identity implementation
  • Changelogs
  • Website documentation (separate repo)

@austinvalle austinvalle added the enhancement New feature or request label Mar 6, 2025
@austinvalle austinvalle added this to the v1.15.0 milestone Mar 6, 2025
@austinvalle austinvalle marked this pull request as ready for review March 14, 2025 12:48
@austinvalle austinvalle requested a review from a team as a code owner March 14, 2025 12:48
ansgarm