Skip to content

Cherry-pick #8195 into v1.71.x #8202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arjan-bal merged 2 commits into from
Mar 26, 2025
Merged

Cherry-pick #8195 into v1.71.x #8202

arjan-bal merged 2 commits into from
Mar 26, 2025

Conversation

@arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Mar 26, 2025

Original PR: #8195
Related Issue: #8168

RELEASE NOTES:

  • resolver/delegatingresolver: Avoid deadlocks when an http proxy is configured and a resolver calls UpdateState synchronously while handling a ResolveNow call.
  • resolver/delegatingresolver: Fix race that may cause panics when an http proxy is configured and the resolver is closing.

@arjan-bal arjan-bal added this to the 1.71 Release milestone Mar 26, 2025
@codecov
Copy link

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (208e03b) to head (720552e).
Report is 1 commits behind head on v1.71.x.

Additional details and impacted files 
@@             Coverage Diff             @@
##           v1.71.x    #8202      +/-   ##
===========================================
+ Coverage    82.39%   82.43%   +0.04%     
===========================================
  Files          387      387              
  Lines        38942    38959      +17     
===========================================
+ Hits         32086    32116      +30     
+ Misses        5551     5543       -8     
+ Partials      1305     1300       -5
Files with missing lines Coverage Δ
.../resolver/delegatingresolver/delegatingresolver.go 82.22% <100.00%> (+5.53%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal requested review from dfawley and purnesh42H March 26, 2025 17:45
@dfawley dfawley assigned arjan-bal and unassigned purnesh42H and dfawley Mar 26, 2025
@arjan-bal arjan-bal merged commit 3a93562 into grpc:v1.71.x Mar 26, 2025
14 of 15 checks passed
@arjan-bal arjan-bal deleted the cherry-pick/8195 branch March 27, 2025 04:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators