Skip to content

Conversation

mstoykov
Copy link
Contributor

What?

update golangci-lint to latest version

Quite a lot of gosec ones about integers under/overflows - I tried to fix the ones that weren't problematic, but there were quite a lot.

Why?

Keeping up to date makes it easier to update and it is harder for IC to keep the exact version we use locally and unfortuantely there are always differences.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Quite a lot of gosec ones about integers under/overflows - I tried to
fix the ones that weren't problematic, but there were quite a lot.
@mstoykov mstoykov added this to the v0.56.0 milestone Dec 10, 2024
@mstoykov mstoykov requested a review from a team as a code owner December 10, 2024 14:56
@mstoykov mstoykov requested review from joanlopez and oleiade and removed request for a team December 10, 2024 14:56
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping in mind number of the type conversions, int/uint/etc with omitting of the gosec it sounds that it might be so that we probably need some refactoring, on the other side it's for sure out of scope of this PR, so LGTM 👍

Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mstoykov mstoykov merged commit 1d1afd0 into master Dec 12, 2024
22 of 23 checks passed
@mstoykov mstoykov deleted the golangciLintUpdate branch December 12, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants