Update: To support year in ecmaVersion number (fixes #300) #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do we want to duplicate the normalizing logic in ESLint still? https://github.com/eslint/eslint/blob/cbbe420433726a5c7f38b132efac2945053966d5/lib/eslint.js#L427 |
Member
Author
|
I will work on that once I have this PR merged. |
Member
|
We should leave the ESLint logic as-is because it affects more than just Espree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need Feedback: Should we print different error messages for the year based vs pure numbers or we just use a common error message.