feat: circular autofix/conflicting rules detection #19514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
nzakas
reviewed
Mar 14, 2025
Member
nzakas
left a comment
There was a problem hiding this comment.
The code looks good to me. Can we also add a troubleshooting page that describes this error and what to do about it? I can imagine someone seeing this error and not understanding what it means or what to do about it.
Member
Author
|
Added a troubleshooting page in e423966. |
nzakas
previously approved these changes
Mar 17, 2025
Member
nzakas
left a comment
There was a problem hiding this comment.
Just cleaned up the docs a bit, but otherwise LGTM.
Co-authored-by: Nicholas C. Zakas <[email protected]>
Co-authored-by: Nicholas C. Zakas <[email protected]>
mdjermanovic
commented
Mar 17, 2025
nzakas
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
Fixes #17609.
What changes did you make? (Give an overview)
Updated
Linter#verifyAndFix()to check if the produced fix in a pass is the same as in the second previous pass, and in that case stop and emit a warning about conflicting rules.Is there anything you'd like reviewers to focus on?