feat: support global shortcuts via GlobalShortcutsPortal feature with ozone/wayland
#45297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
codebytere
approved these changes
Jan 28, 2025
96a16ad to
a0e6bfe
Compare
a0e6bfe to
6f7a280
Compare
This backports a patch from Chromium, which fixes systemd unit activation. That is, a globalShortcuts feature that Chromium has needs to create a systemd unit and rename it properly. Portal's global shortcuts uses that name afterwards to map the app with the shortcuts bound. However, there might be a race between Chromium binding shortcuts and renaming the unit. This is a first step to add Portal's globalShortcuts to Electron. Co-authored-by: Maksim Sisov <[email protected]>
Chromium has a new feature called GlobalShortcutsPortal. It allows clients to use Portal's globalShortcuts to register and listen to shortcuts. This patches adds necessary bits, which allows Electron to use that feature. In order to make it work, one has to add --enable-features=GlobalShortcutsPortal Test: tested manually with a sample app. Co-authored-by: Maksim Sisov <[email protected]>
869cf84 to
aaba99d
Compare
Electron supports Portal's globalShortcuts API now via Chromium, and Electron apps can use that in a Wayland session. Update the docs with the required feature flag that must be passed to be able to use that implementation. Co-authored-by: Maksim Sisov <[email protected]>
aaba99d to
ea9ced2
Compare
GlobalShortcutsPortal feature with ozone/wayland
|
hey @Obsessee i'm fixing it up now and will merge after this CI run hopefully passes. |
Magnate1234
reviewed
Feb 26, 2025
|
Release Notes Persisted
|
|
Something is wrong with our CI, this PR went green but it shouldn't've been able to build...? I don't know how CI went green but landing this causes 35-x-y (and today's release of 35.0.0-beta.11) to fail to compile. This change is already present in 134.0.6998.23 and doesn't need to be patched in. Doesn't look like this is some kind of two-PRs-in-flight-at-the-same-time issue either. @electron/wg-infra can someone PTAL? I've put up a PR to remove the patch @ #45838 |
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #45171
See that PR for details.
Notes: support Portal's globalShortcuts. Electron must be run with --enable-features=GlobalShortcutsPortal in order to have the feature working.