Add a test to define behavior when empty parameters are passed #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Campbell <[email protected]>
6a02a71 to
82d1000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a single test to define behavior when an empty string is passed to the input list.
For context, my team was trying to determine a proper default value to set in a re-packaged internal version of docker/build-push-action@v4's
platformfield. We wanted to make this configurable, but wanted to provide a valid default value that wouldn't change behavior as we previously didn't set this. Checking the source, led us here where we didn't find it included in the test spec. Adding this test should make the expected behavior well defined and allow folks to depend on it.