refactor(zone.js): Add internal implementation for auto ticking fakeA… #62135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c75cc25 to
b26afad
Compare
…sync Benefits of auto-ticking mock clocks have been described in other PRs, such as jasmine/jasmine#2042 and sinonjs/fake-timers#509. In short, `fakeAsync` cannot work when some tasks are required to be truly async, such as XHRs or observers like ResizeObserver. In addition, auto ticking mock clocks can be applied to tests without the tests then needing to update everything to manually flush timers.
9cfe5db to
559844b
Compare
Contributor
|
caretaker note: TGP is green. This is safe to merge. |
atscott
added a commit
that referenced
this pull request
Aug 8, 2025
…sync (#62135) Benefits of auto-ticking mock clocks have been described in other PRs, such as jasmine/jasmine#2042 and sinonjs/fake-timers#509. In short, `fakeAsync` cannot work when some tasks are required to be truly async, such as XHRs or observers like ResizeObserver. In addition, auto ticking mock clocks can be applied to tests without the tests then needing to update everything to manually flush timers. PR Close #62135
Contributor
Author
|
This PR was merged into the repository by commit 0a827f9. The changes were merged into the following branches: main, 20.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sync
Benefits of auto-ticking mock clocks have been described in other PRs, such as jasmine/jasmine#2042 and sinonjs/fake-timers#509. In short,
fakeAsynccannot work when some tasks are required to be truly async, such as XHRs or observers like ResizeObserver. In addition, auto ticking mock clocks can be applied to tests without the tests then needing to update everything to manually flush timers.