Skip to content

fix(zone.js): more robust check for promise-like objects #57388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

fix(zone.js): more robust check for promise-like objects #57388

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 14, 2024

Fixes that Zone.js wasn't checking properly if an object is promise-like.

Fixes #57385.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: zones Issues related to zone.js target: patch This PR is targeted for the next patch release labels Aug 14, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 14, 2024
@pullapprove pullapprove bot requested a review from JiaLiPassion August 14, 2024 09:22
@crisbeto
fix(zone.js): more robust check for promise-like objects
77adff3 
Fixes that Zone.js wasn't checking properly if an object is promise-like.

Fixes angular#57385.
@crisbeto crisbeto force-pushed the 57385/zone-thenable branch from 82782e9 to 77adff3 Compare August 20, 2024 18:27
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker PullApprove: disable and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 23, 2024
@crisbeto crisbeto removed the request for review from JiaLiPassion August 23, 2024 04:46
@crisbeto
Copy link
Member Author

crisbeto commented Aug 23, 2024

Disabling PullApprove because the change is LGTMed and is pretty basic.

@alxhub
Copy link
Member

alxhub commented Aug 23, 2024

This PR was merged into the repository by commit e608e6c.

The changes were merged into the following branches: main, 18.2.x

@alxhub alxhub closed this in e608e6c Aug 23, 2024
alxhub pushed a commit that referenced this pull request Aug 23, 2024
@crisbeto @alxhub
fix(zone.js): more robust check for promise-like objects (#57388)
2a89e18 
Fixes that Zone.js wasn't checking properly if an object is promise-like.

Fixes #57385.

PR Close #57388
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 23, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

The isThenable function inside zone.js cause an unexpected exception

2 participants

@crisbeto @alxhub