Skip to content

fix(zone.js): Add support for additional jest functions. #57280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

fix(zone.js): Add support for additional jest functions. #57280

JeanMeche wants to merge 1 commit into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Aug 6, 2024 •
edited
Loading

This commit add support for test.failing and it.failing.

Fixes #57277

@JeanMeche JeanMeche force-pushed the zone/jest branch 2 times, most recently from fd59a5c to 7d6d376 Compare August 6, 2024 19:32
@JeanMeche
fix(zone.js): Add support for addition jest functions.
74b18c3 
This commit add support for `test.failing` and `it.failing`.

Fixes angular#57277
@JeanMeche JeanMeche mentioned this pull request Aug 6, 2024
Closed
@JeanMeche JeanMeche marked this pull request as ready for review August 7, 2024 14:15
@JeanMeche JeanMeche changed the title fix(zone.js): Add support for addition jest functions. fix(zone.js): Add support for additional jest functions. Aug 7, 2024
@pullapprove pullapprove bot requested a review from JiaLiPassion August 7, 2024 14:15
@thePunderWoman thePunderWoman added the area: zones Issues related to zone.js label Aug 7, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 7, 2024
thePunderWoman
thePunderWoman approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 7, 2024
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Aug 7, 2024

Caretaker note: this is safe to merge with current approvals.

thePunderWoman pushed a commit that referenced this pull request Aug 7, 2024
@JeanMeche @thePunderWoman
fix(zone.js): Add support for addition jest functions. (#57280)
69540d3 
This commit add support for `test.failing` and `it.failing`.

Fixes #57277

PR Close #57280
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Aug 7, 2024

This PR was merged into the repository by commit e1240c6.

The changes were merged into the following branches: main, 18.1.x

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@JiaLiPassion JiaLiPassion Awaiting requested review from JiaLiPassion

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

[Zone.js] it.failing and test.failing seem to be not patched for Jest

2 participants

@JeanMeche @thePunderWoman