Skip to content

Add Mint example #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tanuj077 merged 4 commits into from
Dec 30, 2022
Merged

Add Mint example #1051

tanuj077 merged 4 commits into from
Dec 30, 2022

Conversation

@uhooi
Copy link
Contributor

@uhooi uhooi commented Dec 29, 2022

Description

Reopen #378 .

Tried with Mint 0.17.5 .

ref: https://github.com/yonaskolb/Mint#advanced

Motivation and Context

Help all users of Mint.

How Has This Been Tested?

I tried it on my app.

Screenshots (if appropriate):

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@uhooi uhooi requested a review from a team as a code owner December 29, 2022 13:40
@github-actions github-actions bot requested a review from tanuj077 December 29, 2022 13:41
@tanuj077
Copy link
Contributor

tanuj077 commented Dec 30, 2022

Thanks @uhooi for raising the PR.

tanuj077
tanuj077 approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@tanuj077 tanuj077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tanuj077 tanuj077 merged commit 365406c into actions:main Dec 30, 2022
@uhooi uhooi deleted the feature/add_mint_example branch December 30, 2022 05:32
@mikelane mikelane mentioned this pull request Jan 10, 2023
Merged
@renovate renovate bot mentioned this pull request Sep 14, 2023
Open
1 task
This was referenced Nov 13, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tanuj077 tanuj077 tanuj077 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tanuj077 tanuj077

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uhooi @tanuj077