Toolchain for Test task #3064
Toolchain for Test task #3064
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3064 +/- ##
=========================================
Coverage 85.45% 85.45%
Complexity 2888 2888
=========================================
Files 329 329
Lines 8801 8801
Branches 1093 1093
=========================================
Hits 7521 7521
Misses 992 992
Partials 288 288 ☔ View full report in Codecov by Sentry. |
|
Do you know why the code coverage has increased with this PR? Looking at the changes, I don't see a particular reason why they would cover more. Or is this the result of running on Java 17 for Android? If so, are we also missing coverage now? I didn't spot anything, but let's double check. Great change btw. We should definitely start using toolchains and now it is clear what we are using when. |
@TimvdLippe the coverage changed because master android CI failed, so coverage from instrumentation tests was not included in baseline the PR is compared against. They passed on this PR, so they're covered, that's the increase. If you re-run this job on master so it passes, it should equalize. Please do. |
|
@TWiStErRob can you rebase on master? I merged some Dependabot PRs and unfortunately they now clash. That should also fix the coverage issue, as I reran that job |
Using a toolchain installed via auto-provisioning, but having no toolchain repositories configured. This behavior is deprecated. Consider defining toolchain download repositories, otherwise the build might fail in clean environments; see https://docs.gradle.org/8.2/userguide/toolchains.html#sub:download_repositories
|
Clean rebase, only the trivial conflict with enterprise bump. |
|
@TimvdLippe Coverage diff looks good. Do you agree with changes listed here? The biggest one is producing Java 11 bytecode on Java 17 for production code. |
Re-raise of TWiStErRob#1 in mockito repo.
A step towards #2898, from here we could create multiple test tasks as a followup, and remove the gradle property and use the task name as dynamic matrix element instead.
Testing: see section in #3062
Additionally I added
fail(System.getProperty("java.home"))in a test to see if the JDK was as expected.I tried to minimize the changes, that's why I created a separate PR to make it possible to configure all projects at once.
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant