Skip to content

Documentation about MockMakers slightly outdated in some places. Fixes #3031 #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2023
Merged

Documentation about MockMakers slightly outdated in some places. Fixes #3031 #3032

merged 1 commit into from
Jun 8, 2023

Conversation

reta
Copy link
Contributor

@reta reta commented Jun 7, 2023

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@reta
Copy link
Contributor Author

reta commented Jun 7, 2023

@TimvdLippe @mr1chter would appreciate if you could take a look folks, addressing the gaps in the documentation, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (be98090) 85.70% compared to head (1089b3d) 85.70%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #3032   +/-   ##
=========================================
  Coverage     85.70%   85.70%           
  Complexity     2876     2876           
=========================================
  Files           326      326           
  Lines          8733     8733           
  Branches       1078     1078           
=========================================
  Hits           7485     7485           
  Misses          971      971           
  Partials        277      277
Impacted Files Coverage Δ
src/main/java/org/mockito/Mockito.java 96.62% <ø> (ø)
...nternal/creation/bytebuddy/ByteBuddyMockMaker.java 61.90% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

TimvdLippe
TimvdLippe approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe TimvdLippe merged commit 5daf51a into mockito:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reta @codecov-commenter @TimvdLippe