Skip to content

Gradle 8.3 compatibility: buildDir -> layout.buildDirectory #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2023
Merged

Gradle 8.3 compatibility: buildDir -> layout.buildDirectory #3068

merged 1 commit into from
Jul 21, 2023

Conversation

TWiStErRob
Copy link
Contributor

Not a breaking change in Gradle 8.3, just future-proofing code as Project.buildDir is deprecated in Gradle 8.3-rc-1.

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf8b820) 85.45% compared to head (2ba6195) 85.45%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #3068   +/-   ##
=========================================
  Coverage     85.45%   85.45%           
  Complexity     2888     2888           
=========================================
  Files           329      329           
  Lines          8801     8801           
  Branches       1093     1093           
=========================================
  Hits           7521     7521           
  Misses          992      992           
  Partials        288      288

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

TimvdLippe
TimvdLippe approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe TimvdLippe merged commit 009be85 into mockito:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TWiStErRob @codecov-commenter @TimvdLippe