feature: add support for URL struct tags in struct-tag rule #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisvmedia
reviewed
Feb 16, 2025
| keyJSON = "json" | ||
| keyProtobuf = "protobuf" | ||
| keyRequired = "required" | ||
| keyURL = "url" |
Collaborator
There was a problem hiding this comment.
I'd maybe update the docs to include all supported struct tags explicitly.
Collaborator
Author
There was a problem hiding this comment.
Yes, this PR is one in a series of PR related to struct-tag, I'll will update the doc at the end.
denisvmedia
reviewed
Feb 16, 2025
| var delimiter = "" | ||
| for _, opt := range options { | ||
| switch opt { | ||
| case "int", "omitempty", "numbered", "brackets": |
Collaborator
There was a problem hiding this comment.
It looks like we miss the following: unix, unixmilli, unixnano
Also, I'd consider adding support for layout and del struct tags, since they are a part of the spec for github.com/google/go-querystring/query.
Collaborator
Author
There was a problem hiding this comment.
I' ve added unix* options.
layout and del : almost no-body uses them so I think it does not worth supporting these tags.
Collaborator
|
Thanks. Looks nice and simple. Just a few comments. |
mfederowicz
pushed a commit
to mfederowicz/revive
that referenced
this pull request
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends struct-tag rule to check URL tags as defined at https://github.com/google/go-querystring (cf https://go.dev/wiki/Well-known-struct-tags#list-of-well-known-struct-tags)